I found Hans's comment on this dated 16 Jan:
- It seems like the logic in ng_ccb_apply_modify_hdlr can only handle deletion
of one node at a time. Either that logic is changed or
ng_ccb_completed_modify_hdlr is changed to only allow deletion of one node per
CCB. At this point I would prefer to disallow deletes of more than one node at
a time.
Hans, do you want it to document or fallback to old behaviour by creating a
ticket ?
---
** [tickets:#719] AMFD: Invalid read when deleting a node from a node group**
**Status:** fixed
**Milestone:** 4.4.RC1
**Created:** Wed Jan 15, 2014 05:35 AM UTC by Gary Lee
**Last Updated:** Fri Jun 13, 2014 06:53 AM UTC
**Owner:** Gary Lee
When deleting a node from a node group, valgrind sometimes reports an invalid
read.
Possible solution:
Ensure we don't try to read beyond our array, if the removed node happens to be
the last element in the array.
~~~~
diff --git a/osaf/services/saf/amf/amfd/nodegroup.cc
b/osaf/services/saf/amf/amfd/nodegroup.cc
--- a/osaf/services/saf/amf/amfd/nodegroup.cc
+++ b/osaf/services/saf/amf/amfd/nodegroup.cc
@@ -509,7 +509,7 @@
TRACE("found node %s", ng->saAmfNGNodeList[j].value);
- for (; j < ng->number_nodes; j++)
+ for (; j < (ng->number_nodes - 1); j++)
ng->saAmfNGNodeList[j] = ng->saAmfNGNodeList[j
+ 1];
~~~~
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
