Added in section "2.2.2 Compliance Report":

SaAmfNGNodeList :
1.      Removing more than one values from attribute saAmfNGNodeList of an 
object of class "SaAmfNodeGroup" is not supported in one Ccb modify operation.


changeset:   112:39165941f109
branch:      opensaf-4.3.x
parent:      109:3e423f6c4a8b
user:        Nagendra Kumar<[email protected]>
date:        Thu Jun 19 15:45:51 2014 +0530
summary:     add deviation in modification of SaAmfNodeGroup object [#719]

changeset:   113:6406aa325a7a
branch:      opensaf-4.4.x
parent:      110:fb8246ac5526
user:        Nagendra Kumar<[email protected]>
date:        Thu Jun 19 15:49:16 2014 +0530
summary:     add deviation in modification of SaAmfNodeGroup object [#719]

changeset:   114:67cbdcd9f588
tag:         tip
parent:      111:35df749af8ae
user:        Nagendra Kumar<[email protected]>
date:        Thu Jun 19 15:53:06 2014 +0530
summary:     add deviation in modification of SaAmfNodeGroup object [#719]


[staging:391659]
[staging:6406aa]
[staging:67cbdc]



---

** [tickets:#719] AMFD: Invalid read when deleting a node from a node group**

**Status:** fixed
**Milestone:** 4.4.RC1
**Created:** Wed Jan 15, 2014 05:35 AM UTC by Gary Lee
**Last Updated:** Thu Jun 19, 2014 10:22 AM UTC
**Owner:** Gary Lee

When deleting a node from a node group, valgrind sometimes reports an invalid 
read.

Possible solution:

Ensure we don't try to read beyond our array, if the removed node happens to be 
the last element in the array.

~~~~
diff --git a/osaf/services/saf/amf/amfd/nodegroup.cc 
b/osaf/services/saf/amf/amfd/nodegroup.cc
--- a/osaf/services/saf/amf/amfd/nodegroup.cc
+++ b/osaf/services/saf/amf/amfd/nodegroup.cc
@@ -509,7 +509,7 @@
 
                        TRACE("found node %s", ng->saAmfNGNodeList[j].value);
 
-                       for (; j < ng->number_nodes; j++)
+                       for (; j < (ng->number_nodes - 1); j++)
                                ng->saAmfNGNodeList[j] = ng->saAmfNGNodeList[j 
+ 1];
~~~~


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to