- **status**: review --> fixed
- **Comment**:
changeset: 6234:6856d2dc4fa2
parent: 6231:049e060d68c4
user: A V Mahesh <[email protected]>
date: Fri Jan 09 14:53:12 2015 +0530
summary: mds: correct memcopy size of contiguous USRBUF in fragment send
[#1239]
changeset: 6233:342cb9e3e4ab
branch: opensaf-4.5.x
parent: 6229:78c53c4b977c
user: A V Mahesh <[email protected]>
date: Fri Jan 09 14:52:59 2015 +0530
summary: mds: correct memcopy size of contiguous USRBUF in fragment send
[#1239]
changeset: 6232:71cb8534b63b
branch: opensaf-4.4.x
parent: 6228:aea6e7294378
user: A V Mahesh <[email protected]>
date: Fri Jan 09 14:52:43 2015 +0530
summary: mds: correct memcopy size of contiguous USRBUF in fragment send
[#1239]
---
** [tickets:#1239] mds: wrong size memcpy if USRBUF chain(payload) are
contiguous memory **
**Status:** fixed
**Milestone:** 4.6.FC
**Created:** Mon Jan 05, 2015 04:36 AM UTC by A V Mahesh (AVM)
**Last Updated:** Tue Jan 06, 2015 10:22 AM UTC
**Owner:** A V Mahesh (AVM)
In the process of code walk in the context of debugging some application
segfault, we fund on bug , USRBUF contiguous memory ( non-stranded-path system
has vey less memory) case of fragment and send function.
If USRBUF chain(payload) are contiguous MMGR_DATA_AT_START doesn't copy the
buffer , application need to copy the buffer, in that memcpy() the size was
wrong/overflowing.
This need to be corrected as follws
@@ -2246,7 +2246,7 @@ uint32_t mdtm_frag_and_send(MDTM_SEND_RE
-
memcpy(&body[SUM_MDS_HDR_PLUS_MDTM_HDR_PLUS_LEN], p8, len_buf);
+
memcpy(&body[SUM_MDS_HDR_PLUS_MDTM_HDR_PLUS_LEN], p8, (len_buf -
SUM_MDS_HDR_PLUS_MDTM_HDR_PLUS_LEN));
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
vanity: www.gigenet.com
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
