5\. some places: setenv(): return value not checked.

6\. smfsv_evt.c: smf_enc_cbk_req(): branch_past_initialization problem for 
"length" variable: this problem is shown only by coverity so far. It is better 
to fix since it can cause problems with some compilers.
Proposal is to initialize at the begining of the function. That means it will 
be initialized and maybe not used (some of the goto cases). Other: variable 
"rc" not needed.

7\. smfd_smfnd: smfnd_up(): this method has 2 pairs of mutex lock/unlock. The 
data is unreliable between these. Solution is to keep the first lock and last 
unlock. Also introduce unlocks at each return.


---

** [tickets:#1154] smf: defects detected by Coverity tool should be fixed**

**Status:** assigned
**Milestone:** 4.6.FC
**Created:** Mon Oct 06, 2014 11:38 AM UTC by Robert Apanowicz
**Last Updated:** Tue Feb 03, 2015 01:20 PM UTC
**Owner:** Robert Apanowicz

This ticket is the placeholder for all the defects of SMF which are detected by 
Coverity tool.


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to