8\. SmfUpgradeStep::modifyInformationModel(): logically dead code at the end of
while loop. If statement handles 3 cases (continue/return/break) where none of
them let to reach the bottom of while loop. Coverity complaining about not
running the destructor of the instance of SmfRollbackCcb (constructed each turn
of the loop). Possible solution is to not construct each turn, since data not
modified, but move the contructing before the loop.
9\. SmfProcedureThread::handleEvents(): return value of "handleEvents" and
"deleteImmHandle" not checked.
10\. SmfUpgradeProcedure::createImmStep(): return value of "find" not checked.
Without checking the result of "find", "pos" value is subtracted from it, then
that value is provided directly to "substr" as input argument. For
functionality it does not make a problem, but the substraction is unnecessary
if "find" returns "npos".
11\. SmfStepTypeNodeReboot::rollback(): "checkAndInvokeCallback()" called twice
after each other which is an obvious fault. (Coverity: at the first call the
return value is not checked).
---
** [tickets:#1154] smf: defects detected by Coverity tool should be fixed**
**Status:** assigned
**Milestone:** 4.6.FC
**Created:** Mon Oct 06, 2014 11:38 AM UTC by Robert Apanowicz
**Last Updated:** Wed Feb 04, 2015 10:30 AM UTC
**Owner:** Robert Apanowicz
This ticket is the placeholder for all the defects of SMF which are detected by
Coverity tool.
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
