- **status**: fixed --> accepted


---

** [tickets:#2963] amfd: node failover state set incorrectly on standby**

**Status:** accepted
**Milestone:** 5.18.12
**Created:** Thu Nov 15, 2018 11:10 PM UTC by Gary Lee
**Last Updated:** Fri Nov 16, 2018 01:24 AM UTC
**Owner:** Gary Lee


There is a mistake in NodeStateMachine::SetState(uint32_t state):

~~~
// this is called as a result of check pointing from the active
void NodeStateMachine::SetState(uint32_t state) {
..
    case NodeState::kEnd:
      state_ = std::make_shared<FailedFound>(this);
      cb_->failover_list.erase(node_id_);
      break;
 ..
}
~~~

state is incorrectly set to FailedFound instead of End. Functionally it has 
next to no effect, because the next line of code deletes the state machine. But 
the incorrect transition to FailedFound means a timer is started for no reason, 
and stopped immediately after.


---

Sent from sourceforge.net because [email protected] is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
_______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to