commit c43ae9d97d169cc4a3b57da14ed9191dca8dfba5
Author: Gary Lee <[email protected]>
Date: Fri Nov 16 06:33:18 2018 +0000
amfd: add node to failover_list before calling SetState [#2963]
node must be added to failover_list before SetState() is called.
If the state is 'end', then it will be deleted by SetState().
Otherwise, we will leave a node in 'End' state mistakenly in
failover_list.
---
** [tickets:#2963] amfd: node failover state set incorrectly on standby**
**Status:** accepted
**Milestone:** 5.18.12
**Created:** Thu Nov 15, 2018 11:10 PM UTC by Gary Lee
**Last Updated:** Fri Nov 16, 2018 06:35 AM UTC
**Owner:** Gary Lee
There is a mistake in NodeStateMachine::SetState(uint32_t state):
~~~
// this is called as a result of check pointing from the active
void NodeStateMachine::SetState(uint32_t state) {
..
case NodeState::kEnd:
state_ = std::make_shared<FailedFound>(this);
cb_->failover_list.erase(node_id_);
break;
..
}
~~~
state is incorrectly set to FailedFound instead of End
---
Sent from sourceforge.net because [email protected] is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list._______________________________________________
Opensaf-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
