On Mon, Mar 05, 2007 at 04:37:14PM -0600, Douglas E. Engert wrote:
> Any chance getting the patch for the PIV compression ticket #128
> into this release?

I think it looks good at a glance.

Does it apply cleanly to svn?

Has it been tested?


Two general comments:

1. I would prefer if the p15card-helper bit was made into a separate
patch to be applied first.

2. Does the copyright belong to Identity Alliance or Thomas Harning
or both? Currently both are in the notice. In another project we use
(for the Identity Alliance case):

/*
 * Copyright (C) 2006 Identity Alliance
 * Written by Thomas Harning <[EMAIL PROTECTED]> for Identity Alliance
 */

..so it is ultra clear.


//Peter
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to