On Tue, 2007-03-06 at 13:11 +0100, Peter Stuge wrote: > On Mon, Mar 05, 2007 at 04:37:14PM -0600, Douglas E. Engert wrote: > > Any chance getting the patch for the PIV compression ticket #128 > > into this release? > > I think it looks good at a glance. > > Does it apply cleanly to svn? > (Not sure on that... haven't worked w/ OpenSC for a little while) > Has it been tested? > We've tested it on end-state PIV cards, ones that we have programmed, and used the compression utility for a few other items we've worked on. > > Two general comments: > > 1. I would prefer if the p15card-helper bit was made into a separate > patch to be applied first. > > 2. Does the copyright belong to Identity Alliance or Thomas Harning > or both? Currently both are in the notice. In another project we use > (for the Identity Alliance case): > > /* > * Copyright (C) 2006 Identity Alliance > * Written by Thomas Harning <[EMAIL PROTECTED]> for Identity Alliance > */ Sorry it wasn't more clear. The copyright for those patches would belong to Identity Alliance. Feel free to modify the headers to better match the necessary format... -- Thomas Harning Jr. Authentication Engineer @ Identity Alliance http://www.trustbearer.com/
_______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
