Alon Bar-Lev wrote: > On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: >> With your changes today to svn for internal-winscard.h, and reader-pcsc.c >> and the attached change to src/include/winconfig.h all the tools work. >> >> WIN32_LEAN_AND_MEAN, and #include <WinScard.h> work with reader-pcsc.c > > Great! > Please keep small casing for include files. > >> If you can generate versions.rc and the winconfig.h files during automake, >> that would be great. I still have some of the opensc-tool #ifdef'ed out >> that prints the VERSION... These could be in the winconfig.h > > Please remove these. Define something in winconfig.h, and I will fill these > using autoconf. > >> I still have rutoken #ifdef'ed out, and need to look at the exports. >> Only opensc.def and pkcs15init.def are need using the Windows build. > > Waiting for new patch with these also. > >> Index: winconfig.h >> =================================================================== >> --- winconfig.h (revision 3460) >> +++ winconfig.h (working copy) >> @@ -2,7 +2,9 @@ >> #define _OPENSC_WINCONFIG_H >> >> #include <stdio.h> >> +#define WIN32_LEAN_AND_MEAN > > This should go into Makefiles and not in include file, as it should > effect the whole > compilation process in Windows.
It does, as as the winconfig.h is the config.h Everything compiled with WIN32_LEAN_AND_MEAN > >> #include <windows.h> >> +#include <WinScard.h> > > Small casing, please. > >> #include <sys/timeb.h> >> >> #ifndef strcasecmp >> @@ -65,13 +67,14 @@ >> #endif >> >> #define HAVE_IO_H >> -#define HAVE_GETPASS >> -#define HAVE_PCSC >> +#define ENABLE_PCSC >> +#define USE_WINDOWS_PCSC > > I don't think the USE_WINDOWS_PCSC is needed. No, was going to use that. > >> +#define DEFAULT_PCSC_PROVIDER "winscard.dll" >> >> #define PATH_MAX _MAX_PATH >> >> #ifndef VERSION >> -#define VERSION "0.11.4" >> +#define VERSION "0.11.4.2" >> #endif > > Please define PACKAGE_VERSION to be VERSION. > Also please add PACKAGE_NAME. > And remove the other #ifdefs you added because of this. OK, next week... > > Thanks! > > -- Douglas E. Engert <[EMAIL PROTECTED]> Argonne National Laboratory 9700 South Cass Avenue Argonne, Illinois 60439 (630) 252-5444 _______________________________________________ opensc-devel mailing list [email protected] http://www.opensc-project.org/mailman/listinfo/opensc-devel
