Am Freitag, 15. August 2008 07:14:12 schrieb Weitao Sun:
> Hello,
>
> The attachment is the patch file. Let me know if you have any comments.
> Thank you.
Hi Weitao,
thanks for sending the diff. a few small comments:
* please use 19000 as base so you have different constant than the AKIS card.
/* TUBITAK UEKAE cards */
SC_CARD_TYPE_AKIS_BASE = 18000,
- SC_CARD_TYPE_AKIS_GENERIC
+ SC_CARD_TYPE_AKIS_GENERIC,
+
+ /* EnterSafe cards */
+ SC_CARD_TYPE_ENTERSAFE_BASE = 18000,
+ SC_CARD_TYPE_ENTERSAFE_3K,
};
you added an ATR to starcos? can you give more details about what card
that is?
+ { "EnterSafe", sc_pkcs15emu_entersafe_init_ex },
IIRC all names are currently lowecase, so I'd prefer to keep it that way,
e.g. "entersafe" instead of "EnterSafe". also rename the profile file and
registe the driver as "entersafe".
can you create a wiki page for this card? I guess the card is both available
as smart card and as usb crypto token (ePass 3000)?
what profiles does the init support? normal setup (so user plus normal user)?
also the "onepin" option (pkcs15-init -p pkcs15+onepin -C) which has only
one user managing everything?
is the resulting card if initiliazed with opensc compatible to the same card
initialized with your software on windows, mac or linux?
also I noticed: you have some announcement on a linux SDK on the web page,
but every download for linux is a broken link / the directory doesn't contain
any of the files. the other files are encrypted, the password is nowhere
mentioned (but was easy to guess). in no file I found an APDU level manual -
is there one for this card / the ePass 3000 token?
I'm no expert on opensc internals and writing drivers, but your code looks
clean and nice, and if noone comes up with other issues, I'd say: lets
include it :)
Regards, Andreas
_______________________________________________
opensc-devel mailing list
[email protected]
http://www.opensc-project.org/mailman/listinfo/opensc-devel
