Ludovic Rousseau wrote:
> On Mon, Aug 18, 2008 at 10:25 PM, Andreas Jellinghaus
> <[EMAIL PROTECTED]> wrote:
>   
>> Am Freitag, 15. August 2008 07:14:12 schrieb Weitao Sun:
>>     
>>> Hello,
>>>
>>> The attachment is the patch file.  Let me know if you have any comments.
>>> Thank you.
>>>       
>> Hi Weitao,
>>
>> thanks for sending the diff. a few small comments:
>>     
>
> Same comments as Andreas.
>
> Why do you need to patch src/pkcs15init/pkcs15-lib.c?
>
> @@ -2793,9 +2794,13 @@
>
>     r = sc_pkcs15_encode_df(card->ctx, p15card, df, &buf, &bufsize);
>     if (r >= 0) {
> +        sc_file_t *file;
> +        r = sc_profile_get_file_by_path(profile, &df->path, &file);
> +        if(r<0) return r;
>         r = sc_pkcs15init_update_file(profile, card,
> -               df->file, buf, bufsize);
> +               file, buf, bufsize);
>         free(buf);
> +       sc_file_free(file);
>     }
>
>     return r < 0 ? r : 0;
Hi Ludovic,

When debugging function sc_pkcs15init_change_attrib using iceweasel(3.0.1), I 
notice that it use the df->file to 

update. But the file's acl entry of "update" is empty ,this 
causes problem later in sc_pkcs15init_update_file with error info "security 
status not satisfied".

Shouldn't sc_pkcs15init_change_attrib get the file from profile as 
sc_pkcs15init_update_any_df does?

I'm new to OpenSC, any suggestion about this issue?

-- 
Weitao Sun <[EMAIL PROTECTED]>
TEL:+86 010 62304466 ext. 585
FAX:+86 010 62304477

Entersafe R&D Dep.<www.entersafe.com>
Feitian Technologies Co., Ltd.<www.ftsafe.com>
5th Floor, Building 7A, No.40 Xueyuan Road
Haidian District, Beijing, P.R. China, 100083



_______________________________________________
opensc-devel mailing list
[email protected]
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to