On Feb 3, 2011, at 10:04 PM, Douglas E. Engert wrote: > I have updates #321 with a new version of the cardmod patch > and would like to start to commit it in pieces. > > Piece 1 is the attachment I sent on 1/28 as new.martin.patch > based on Martin's patch from 1/19. This was the patch that would > work for Brian. The main change is adding two parameters to all > the *_detect_readers routines. Martin's patch already required these > to be added in a number of places. > > Is there any objection to adding this patch now?
I would consider using a new hook, like "use_reader" or "use_pcsc_parameters" to send the arguments to reader-pcsc.c and set the (pcsc, not cardmod) driver to "cardmod state". The reader operations API is by no means set in stone. Nor is there need to abstract it away too much, the usage pattern is known and the code path to implement it should be as simple as possible (sc_XXX wrapper that will not be used by any other reader driver, like sc_cancel and sc_wait_for_event are examples of "somewhat bad ideas". Yet it is a working pattern.) -- @MartinPaljak.net +3725156495 _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
