More fun regressions. :)

This time it is r5220, and it looks like this chunk was committed by
accident:

Index: src/libopensc/pkcs15.c
===================================================================
--- src/libopensc/pkcs15.c      (revision 5219)
+++ src/libopensc/pkcs15.c      (revision 5220)
@@ -681,7 +676,7 @@
                return NULL;
 
        if (!aid || !aid->len)
-               return card->app[0];
+               return card->app[card->app_count - 1];
 
        for (ii=0; ii < card->app_count; ii++) {
                if (card->app[ii]->aid.len != aid->len)

Since applications we like are sorted first, this code change makes
OpenSC actively choose the applications least likely to work. Not
exactly desired behaviour. :)

PS. Should OpenSC really try unknown applications at all? Seems like
it'll just cause random glitches.

Rgds
-- 
Pierre Ossman            OpenSource-based Thin Client Technology
System Developer         Telephone: +46-13-21 46 00
Cendio AB                Web: http://www.cendio.com

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to