On 14.03.2011 15:38, Pierre Ossman wrote:
> More fun regressions. :)
>
> This time it is r5220, and it looks like this chunk was committed by
> accident:
>
> Index: src/libopensc/pkcs15.c
> ===================================================================
> --- src/libopensc/pkcs15.c (revision 5219)
> +++ src/libopensc/pkcs15.c (revision 5220)
> @@ -681,7 +676,7 @@
> return NULL;
>
> if (!aid || !aid->len)
> - return card->app[0];
> + return card->app[card->app_count - 1];
>
> for (ii=0; ii< card->app_count; ii++) {
> if (card->app[ii]->aid.len != aid->len)
>
> Since applications we like are sorted first, this code change makes
> OpenSC actively choose the applications least likely to work. Not
> exactly desired behaviour. :)
Yes, it's an accident.
Thanks once more.
> PS. Should OpenSC really try unknown applications at all? Seems like
> it'll just cause random glitches.
As for me yes,
it has to be able to read any PKCS#15 application .
> Rgds
Kind wishes,
Viktor.
>
> _______________________________________________
> opensc-devel mailing list
> opensc-devel@lists.opensc-project.org
> http://www.opensc-project.org/mailman/listinfo/opensc-devel
--
Viktor Tarasov <viktor.tara...@opentrust.com>
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
