Hello Frank, On Apr 19, 2011, at 14:41 , Frank Morgner wrote: > On Tuesday, April 19 at 02:03PM, Martin Paljak wrote: >> >> On Mon, Apr 18, 2011 at 23:22, Peter Marschall <pe...@adpm.de> wrote: >>> I guess the library should be deferred for later. >>> It may need discussions where the code shall go: maybe even directly into >>> libopensc ;-) >> OK, all commited. >> >> Thanks! > > Please note my remarks on the patch for extended lengths: > http://www.opensc-project.org/opensc/ticket/260#comment:4
Sorry, I missed those comments on that ticket when dealing with those 3 patches. Looking at your patch - I like the approach more: - removes code duplication (there's one more instance in piv-tool.c) - feels like easier to read (but verification would need attention what I can't afford right now, sickathome) - has a nice debug log statement. It would be nice if the patch - removed the 3rd instance of same code in piv-tool.c (and reverted r5370) - had some doxygen documentation in apdu.c and opensc.h - not really important, but probably would be good if the function had a name similar to the reverse function (apdu2bytes) Peter, can you verify if this works for you as well (and/or is it free of the mentioned memory overrun problem) ? Thanks, Martin -- @MartinPaljak.net +3725156495 _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
