[Ludovic, Please see below.] On 2/19/2012 7:30 AM, Peter Stuge wrote: > Peter Stuge wrote: >>> Please advise: >>> 1) How to push a patch from GITHUB to OpenSC staging directory. >>> In two or three sentences. >> >> I would do: >> >> One-time setup: >> a. Create Gerrit account and add username and public SSH key >> b. git clone from github which has the patch >> c. cd into cloned dir >> d. Install commit-msg hook >> scp -p -P 8882 www.opensc-project.org:hooks/commit-msg .git/hooks/ >> e. git remote add gerrit ssh://www.opensc-project.org:8882/OpenSC.git >> f. git config remote.gerrit.push HEAD:refs/for/master >> >> For each patch: >> 1. Make the current branch equal to OpenSC GitHub + the patch (git rebase) >> 2. Check that the patch has a Change-Id, if not, git commit --amend -C HEAD >> 3. git push gerrit >> >> In case multiple commits belong together in the same logical change >> or that they depend on each other, then the current branch should >> have all these commits following the last commit of OpenSC GitHub. > > This is my prefered way. I just found confirmation of my guess that a > pull request sent to OpenSC GitHub will also arrive into Gerrit. So > if already using GitHub then that is probably the easiest way.
I am new to Gerrit too, but it looks like if 2 code reviews give a +1, the code will be advanced. See: https://www.opensc-project.org/codereview/ I can use my Google OpenID to Sign In, and today did a code review on: Change I51630a84: Cleanup PKCS15 PIV Card PIN flags This is a change I submitted in December, and Victor gave it a +1 So today I gave it a +1, (As I am the only PIV developer I figure I can review my own code) "Looks good to me, but someone else must approve" But this does not look like it is the same as "Looks good to me, approved" https://www.opensc-project.org/codereview/#admin,group,7 says Ludovic and Martin are the two members of the Integrators group. I might assume Ludovic and Martin are in the Administrator group, but I can not see that. https://www.opensc-project.org/opensc/wiki/DevelopmentPolicy says: "Git write access is granted to those who GetInvolved with OpenSC development and ..." This would imply that there is no intent to keep write access controlled, but it might be controlled today based on the Gerrit access control. Ludovic, Can you verify if you are in the Gerrit Administrator's group? and are any of the other people listed on the "GetInvolved" page listed as integrators, or admins? > > > //Peter > > > > _______________________________________________ > opensc-devel mailing list > opensc-devel@lists.opensc-project.org > http://www.opensc-project.org/mailman/listinfo/opensc-devel -- Douglas E. Engert <deeng...@anl.gov> Argonne National Laboratory 9700 South Cass Avenue Argonne, Illinois 60439 (630) 252-5444 _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
