Douglas E. Engert wrote: > I am new to Gerrit too, All right! I'm by no means an expert, but I have been using it in several projects for a while, where I also helped with issues during the migration, so please feel free to ask any questions.
> but it looks like if 2 code reviews give a +1, the code will be > advanced. > > See: https://www.opensc-project.org/codereview/ Need Code Review +2 means that one "+2" review is neccessary. 2x +1 is not equivalent. > I can use my Google OpenID to Sign In, and today did a code review > on: Change I51630a84: Cleanup PKCS15 PIV Card PIN flags Thanks! Although since it is your patch it is perhaps a bit redundant, since you have likely reviewed your patch locally before sending it anyway. > This is a change I submitted in December, and Victor gave it a +1 > So today I gave it a +1, (As I am the only PIV developer I figure I > can review my own code) I expect every developer to review their own code locally, already before pushing to Gerrit. The fact that you're the PIV expert is inconvenient to formalize a set of rules for, so it's something integrators will simply have to keep in the back of their head, as they look at individual changes. > "Looks good to me, but someone else must approve" > But this does not look like it is the same as "Looks good to me, approved" Indeed, the latter is a "+2" code review. > https://www.opensc-project.org/codereview/#admin,group,7 > says Ludovic and Martin are the two members of the Integrators group. Right, this means that they are able to "submit" or integrate changes from Gerrit into the OpenSC repository on GitHub, by selecting +2 Looks good to me, approved during review, and clicking the "Publish and Submit" button, which is available in the web interface. Ludovic: Keep in mind that selecting +2 and clicking "Publish Comments" is *not* sufficient to integrate that change. Gerrit is a young tool still. :) I personally strongly prefer the SSH interface. If I was an integrator, I could have included your change with the command: ssh -p 8882 www.opensc-project.org gerrit review 51630a844e8e95e7108cb1966c5f3e21b93a463b --code-review +2 -s The hash after the review command is the patch set commit hash. Combination of Change-Id and patch set number should also work, i.e. ssh -p 8882 www.opensc-project.org gerrit review I51630a84,1 --code-review +2 -s although I haven't had success with this anywhere yet. (May be due to old an buggy versions of Gerrit!) > https://www.opensc-project.org/opensc/wiki/DevelopmentPolicy > says: > "Git write access is granted to those who GetInvolved with OpenSC > development and ..." > This would imply that there is no intent to keep write access controlled, > but it might be controlled today based on the Gerrit access control. Gerrit behaves just like a Git repository, and for those more comfortable with GitHub it's also possible to fork OpenSC there and work from that. "Git write access" is almost nonsensical because Git allows everyone to write everywhere. > Ludovic, > Can you verify if you are in the Gerrit Administrator's group? > and are any of the other people listed on the "GetInvolved" page > listed as integrators, or admins? Integrators is only Martin and Ludovic, hence those are the ones who can currently include Gerrit changes into OpenSC on GitHub. Now for the third time, I'm sure that everyone who used to have repository write access will also quickly be added to the Integrator group if they mention their account name or ID and someone in the Administrators group is around. If only Martin is admin, then I guess there's a bit of a wait state, but that's not really such a big deal, because it doesn't block further work in any way. //Peter _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
