I'm debating whether to submit a pull request on github with patches to reduce gcc's warnings to a minimum (actually, completely eliminated.) However, the patches violate the coding rules by marking unused parameters in static functions -- the "marking" is very explicit and very visible.
I also took care of other issues, such as replacing "int" with "size_t" where needed. I should have made the unused param patch separate from the integer conversion and other warnings. Question (and request for comments): Should I submit the pull request, even though the patch would potentially violate the coding conventions? -scooter _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
