On Wed, Sep 26, 2012 at 10:24:34AM -0700, B. Scott Michel wrote: > On 9/22/2012 12:04 AM, Andreas Jellinghaus wrote: > > > > > Do not "fix" unused param warnings. The correct way to fix them is to > > > remove the parameter. > > > > Well, with c style object orientation we have interfaces that all card > > drivers must implement, even if they don't use all function parameters. > > > > Not sure if the marking will still allow people to also compile with > > visual c. > > > > This is easily handled with a preprocessor macro. Currently, I'm using > "__unusedparam__" in front of the unused parameter, which stands out and > is self evident to its purpose. > > But I need to break the patches apart so that the unused param patch > stands on its own.
Just as a datapoint, not meant to criticize your work in any way - in the BSD world it has been a long-standing convention to use __unused after the argument to denote that. Putting it after the argument makes it very easy to declare the "__unused" macro as "__attribute__((unused))" with a check for compilers that actually support it. G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@freebsd.org pe...@packetscale.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 What would this sentence be like if pi were 3?
signature.asc
Description: Digital signature
_______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
