Hi,

On Fri, 2008-05-09 at 10:10 -0500, Carsten Neumann wrote:
>       Hi,
> 
> I've redone the way options are handled by the {Image,Scene}FileHandler 
> and propose attached patch. The main changes are:
> 
> - an option is a name (std::string) and a value (boost::any)
> - an option set is a map from name (std::string) to option
> - {Image,Scene}FileType derive from a common base class (IOFileTypeBase) 
> which holds a stack of option sets that always contains at least one 
> element (the current option set).
> - IOFileTypeBase has some convenience access functions to retrieve 
> options and their values.
> 
> Most loaders have an internal representation for options as well (mainly 
> osb, wrl) which has not been touched except for adjusting the functions 
> that translate the option set into the internal rep.


that does not look right.

boost::any const &
    IOFileTypeBase::getOption(std::string const &name) const
{
    OptionSet::const_iterator oIt = _optStack.top().find(name);
    
    oIt->second;
}

Another one, why do we need 3 different getOption{As} functions in
IOFileTypeBase ?

Otherwise I'm fine with it.

kind regards,
  gerrit




-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Opensg-core mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-core

Reply via email to