Hi, On Fri, 2008-06-13 at 08:51 -0500, Carsten Neumann wrote: > Hi Dirk, > > Dirk Reiners wrote: > > Carsten Neumann wrote: > >> ...this went well, until I encountered OSGProxyGroup.fcd that has a > >> volume field which is a DynamicVolume and of course ifdef magic does not > >> work in the .fcd file... > >> I'm not sure if it is a huge problem if we just punt at this point and > >> leave the DynamicVolume removal as one of the things one has to deal > >> with when transitioning from 1.x to 2. After all, there are more serious > >> changes and whether one does the porting between 1.8.0 and 1.8.1 with > >> OSG_2_PREP defined or 1.8.0 and 2.0 does not make such a big difference > >> IMHO. > >> Of course I'm also open to any ideas on how to get this into 1.x, right > >> now I just can't think of anything that does not involve build system > >> magic, renaming of files or similar horrible machinery. > >> So, any ideas ? > > > > Given that ProxyGroup is very rarely used I think we could ignore this > > one. I'm not quite comfy with right out breaking it though... > > > > I guess we could leave that as an explicit thing to when transitioning, > > as long as it cleanly breaks on compile and not semantically. It should > > be something that can be done relatively easily with a transition script. > > hm, now I'm confused, basically I see these options: > > - keep 1.x as is wrt to DynamicVolume (i.e. not remove it even if > OSG_2_PREP is defined) > > - Unconditionally change the ProxyGroup to use a BoxVolume, which breaks > any .osb files that contain a ProxyGroup (not sure how severe the > breakage would be though, i.e. if it crashes or just fails to restore > the volume). > > - remove the DynamicVolume almost everywhere in 1.x if OSG_2_PREP is > defined except keep in the ProxyGroup. > > I lean towards the first option, as the changes in application code > should be few and most (all?) should cause compile errors. > Ok, so what solution do we go for ?
I would prefer 3 because 99% of the changes will be outside the proxy group, so they can be handled and only the 1% for the proxy group remains until the 2.x move. What happens to the loader in case of Node as this one also includes a dynamic volume (IIRC) This seems to me the bigger issue and reason for solution 1 as compared to the relatively unused proxy group. So still I would prefer to make 3 possible. BTW what happens to old osb files in 2.x ? kind regards, gerrit ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Opensg-core mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensg-core
