Assuming that everything still works after these changes I only have one concern. Namely, why change all the options to be stored in a dictionary indexed by their previous names? This does make much sense to me. I see how you want to split the options up based on groups, but why not just do that by grouping them in the SConstruct file. The previous version was already trying to do this a bit but it wasn't commented to show this.
The other way you could do it is leave the options as named variables but then after all the options have been created create things like required_lib_options as a list and just put references to the named option variables in the list. IMHO it seems like the changes in this section of the code actually made the file larger and a bit more difficult to understand. Anyone else have thoughts on this? -Allen [EMAIL PROTECTED] wrote: > Author: cneumann > Date: Sun Dec 10 12:27:16 2006 > New Revision: 449 > Trac changeset: http://opensg.vrsource.org/trac/changeset/449 > ViewVC: http://realityforge.vrsource.org/viewvc/opensg?view=rev&revision=449 > > Modified: > trunk/SConstruct > Log: > > changed: reorganized build options, > moved build.info processing to a separate class, > moved revision tagging to a separate class, > > This does not fix any problems with the build (hopefully > it does not introduce any new ones as well), but made it > easier for me to understand the whole thing. > > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Opensg-commits mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensg-commits > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Opensg-users mailing list Opensg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensg-users
