Hi Allen,
Allen Bierbaum wrote:
> Assuming that everything still works after these changes I only have one
> concern. Namely, why change all the options to be stored in a
> dictionary indexed by their previous names?
if I used the old names as index that is a mistake, if anything it
should be the new ones.
> This does make much sense
> to me. I see how you want to split the options up based on groups, but
> why not just do that by grouping them in the SConstruct file. The
> previous version was already trying to do this a bit but it wasn't
> commented to show this.
I only wanted to handle all options the same, originally some where put
into variables (jpeg_option, png_option,...) and others where directly
added to the opts container and I wanted the image file format options
grouped together.
> The other way you could do it is leave the options as named variables
> but then after all the options have been created create things like
> required_lib_options as a list and just put references to the named
> option variables in the list.
Yeah, I considered both options, then decided that I actually wanted
both at the same time, but having a list and named variables seemed
strange when I could have a dict instead. That's the only reason and I
don't feel strongly about it :)
> IMHO it seems like the changes in this section of the code actually made
> the file larger and a bit more difficult to understand.
Hm, ok, thats not what I wanted - I'll have another look tomorrow.
> Anyone else have thoughts on this?
Yes, if you have any comments about the OpenSG 2 scons build, please
speak up (that is, unless you want me to make it work on Windows ;) ;)
Thanks,
Carsten
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users
