Hello Edmund,
Edmund Buchal wrote:
> Unfortunately i was not able to reply to your mail before the weekend.
> I have added the source files i have changed to this mail. Just search for
> "isg_bl" in the files to find the changes.
thanks for sending these, I have a couple of questions/comments about it
though:
OSGAttachmentImpl.inl, OSGVRMLNodeDesc.cpp:
thanks for hunting these leaks down. I'll apply a patch.
- OSGFieldContainerFactoryImpl.{h,inl}:
you implemented id reuse in there and switched from using a std::vector
to a std::map for the FieldContainerStore.
Reusing ids is problematic, as there is code that (implicitly) relies on
ids increasing monotonically. On the other hand, if you *do* reuse ids,
I see no need to use a std::map instead of the vector, as the reuse will
keep the vector bounded by the (maximum) number of simultaneously
existing FieldContainers.
If the growth of the FieldContainerStore really is a problem for you
application, I would prefer to switch to a hash_map and not reuse ids.
Your comment in the code says you did not get hash_maps working, what
was the problem you had with those ?
OSGFieldContainerPtrDepImpl.inl:
you changed the deleteContainers function to call destroy for each
aspect, which is not correct. Destroy should only be called once per
container, while destroyAspect should be called for each aspect copy of
a container.
If this fixed a mem leak for you, it is likely that some FieldContainer
does not have a correct implementation of these functions and that is
the place that should be fixed. Do you have information on which
container type caused the leak ?
OSGRemoteAspect.cpp:
you removed definitions of two overloads of getFieldFilter, why ?
OSGVRMLFile.cpp:
this seems to do the same as before, am I missing something ?
Thanks,
Carsten
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users
