Hello Michael,
On 10/10/2011 09:53 AM, Michael Raab wrote:
> I'm back in my office now. Your patch seems to work for as expected. Thanks.
thanks for testing it, applied.
> BTW(1): What is the meaning of the erase operation to the destination string
> in the GroupMCastConnection::disconnect() function?
> line 156: _destination.erase(_destination.begin()+index);
hmm, you are right this looks very bogus, even more so after looking at
the uses of _destination. I've removed this line.
> BTW(2): I was wondering why your patch includes additonal brackes around line
> 533:
> for(m = ack ; m != send&& dgram[m]->getId() != response.getId() ;
> m = (m+1) % _windowSize);
> {
> send = m;
> }
> There's a semicolon closing the for loop in line 531. Just wanted to make
> sure the brackets are not intented for that...
oops, thanks for catching that. I indeed misread the line because I had
missed the semicolon. I'll rewrite this as a while loop to make the
intention clearer...
> BTW(3): How about the network stuff in OpenSG 2. Is it completely new
> delevoped or may these changes also need to be applied to the 2.0 code?
you are right, theses changes also needed to go into 2, thanks for
reminding me.
Cheers,
Carsten
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users
