Hello Johannes,
On 11/21/2011 02:44 AM, Johannes Brunen wrote:
> as a first step, I have extended TriangleIterator and LineIterator to
> support the new adjacency primitive types. Attached you can find a zip file
> containing the modified files and repective patch files. My changes do
> preserve the iterator's semantic, i.e. no access to the adjacency
> information, but only to the 'drawable' primitive information.
if you are working out of a git repository you can also create patches
with git diff or git format-patch (if the changes are committed already).
> Could you (or someone else) please review these changes and if appropriate
> incoporate them into the main repository.
Thank you for the patch! I've committed a slightly modified version,
only changing the formatting a little: The spec quotes were quite long
and since they number the vertices starting at 1 I've found them
slightly confusing. I've trimmed them down and adjusted indices in them
to be 0 based, so they mostly match the offsets used in the code.
> Once, the adajency information is part of the geometry properties it might
> be interesting (?) to iterate over the adjacency infromation itself. What
> would be a good interface in the space of iterators. Should we go for a new
> iterator or should the current iterators become stateful,
Hmm, what do you mean by "become stateful" here, they already are
stateful in the sense that they keep track of where in the current
primitive they are?
> or should we just
> provide additional access functions for the properties? What do you think?
Off-hand it looks like it should be possible to provide the additional
accessors without making the interface too ugly, so that would be ok
with me.
Cheers,
Carsten
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users
