Hello Carsten, "Carsten Neumann" <carsten_neum...@gmx.net> schrieb im Newsbeitrag news:4eca8d68.5030...@gmx.net... > > if you are working out of a git repository you can also create patches > with git diff or git format-patch (if the changes are committed already). > despite from cloning I do not have any experience with git. Should pick up some documention, so...
> > Thank you for the patch! I've committed a slightly modified version, > only changing the formatting a little: The spec quotes were quite long > and since they number the vertices starting at 1 I've found them > slightly confusing. I've trimmed them down and adjusted indices in them > to be 0 based, so they mostly match the offsets used in the code. > I added them directly from the OpenGL spec document to simplify reviewing. Zero based indexing is definitly better for documentation purpose. > > Hmm, what do you mean by "become stateful" here, they already are > stateful in the sense that they keep track of where in the current > primitive they are? > Yes, but I mean that the iterator would get a state which changes its semantic. For instance, if it carries a state 'is_adjacency_iterator = true', then the 'getPosition' interface would provide the adjacency information in contrast to the visible primitive position. >> or should we just >> provide additional access functions for the properties? What do you >> think? > > Off-hand it looks like it should be possible to provide the additional > accessors without making the interface too ugly, so that would be ok > with me. > hmm, I'm not so sure about the uglyness. I have to think about it a little bit longer... Thank you for committing. Best, Johannes ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ Opensg-users mailing list Opensg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensg-users
