Hi,
On 23 Nov, 2011, at 1:44, Carsten Neumann <carsten_neum...@gmx.net> wrote:
> Hello Christoph,
>
> On 11/21/2011 11:27 AM, "Christoph Fünfzig" wrote:
>> I want to do
>> singleton->passiveWin[id]->render (singleton->action[id]);
>> in several threads on the same aspect.
>
> hmm, may I ask why? That sounds like it would cause quite bad thrashing
> on the driver/GPU side...
>
>> In method RenderPartition::dropFunctor(DrawFunctor&, State*, Int32, bool)
>> which belongs to RenderAction, there is
>> "
>> DrawableStatsAttachment *st = DrawableStatsAttachment::get(actCore);
>>
>> if(st == NULL)
>> {
>> DrawableStatsAttachment::addTo(actCore);
>>
>> st = DrawableStatsAttachment::get(actCore);
>> }
>>
>> "
>> which looks not deadlock-free to me (as it adds an attachment to the node),
>
> correct, that is going to cause problems if run concurrently.
And this will not be the only problem. Currently OpenSG is build to run prallel
drawers
on separate aspects. Running multiple drawers in parallel on the same tree in
the same
aspect is not something I would expect to work out of the box without quite
some code
changes.
>
>> Is there the possibility to move this out of the render traversal
>> into a preparation phase "add DrawableStatsAttachment"?
>
> part of the problem is that scene traversal is somewhat expensive for
> OpenSG and if new geometry is added it would need to get an attachment,
> so it's not enough to just run this preparation pass once.
>
>> Or can StatsCollector be switched off completely?
>
> By default the render action does not have a StatCollector; I changed
> the code to only add the attachment and collect statistics if there is a
> collector present (otherwise it's a waste of time anyway).
> Incidentally this also fixes a bug where we were counting triangles twice.
careful, it is not just about statistics. IIRC the occlusion culler also uses
this statistics object, which as far as I remember introduced by the occ.
culler.
Just checking for statistics might not be enough, could you quickly check this.
thanks & kind regards
gerrit
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users
