Hi,

I would like like to report some change proposals.

* In OSGHDRStage.cpp,
HDRStage::generateFragmentProgram the default arguments
do not compile with a recent ATI driver:

        << "vec4 radial(sampler2D tex,"                                  OSGHDRL
        << "            vec2      texcoord,"                                    
 OSGHDRL
        << "            int       samples,"                                     
    OSGHDRL
        << "            float     startScale = 1.0,"                           
OSGHDRL
        << "            float     scaleMul = 0.9)"                             
OSGHDRL

They are not necessary and should be omitted!

* HDRStage::initData(RenderAction *pAction, Int32         iVPWidth, Int32       
  iVPHeight)
there is still an old style "fprinf(stderr, ..". It should use the log:

        SINFO << "use pixe size "
          << pAction->getActivePartition()->getViewportWidth ()
          << " " << pAction->getActivePartition()->getViewportHeight()
          << std::endl;

* In OSGSimpleSHLChunk.cpp (handleGL), OSGShaderProgram.cpp (handleGL)
when compiling or linking does not work, I think the shader source should be 
output for consideration.
This is discussable for longer sources, but a better way for debugging is 
definitely needed.

Thanks,
Christoph

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users

Reply via email to