https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L4473 is bad as well. Adding parameters across multiple lines should always carry an indention.
-BlueWall On Thu, 2015-05-28 at 13:21 -0600, Cinder Roxley wrote: > On May 28, 2015 at 12:54:11 PM, Maxwell, Douglas CIV USARMY ARL (US) > ([email protected]) wrote: > > > > Classification: UNCLASSIFIED > > Caveats: NONE > > > > As a rule, we are adhering to the coding standards of the target > > project. > > In this case our guide is here: > > http://opensimulator.org/wiki/Coding_standards > > > > Our team has been correcting any improperly formatted code as we > > come across > > it. We are finding a lot of mismatched formatting and we believed we > > were > > doing your community a service by performing these corrections as we > > spotted > > them. > > > > If these standards are no longer a part of your standard operating > > procedures, please update your coding standards documentation and we > > will > > adjust accordingly. > > > > Thank you for your comment. > > > > v/r -doug > > Hi, > > > I assume he was referring to the areas that were changed which do > *not* conform to either the opensim coding standing or any coding > standard I’ve ever seen where indentation was removed making the code > much harder to grok such as: > > > https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L3820 > https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L4469 > https://github.com/opensim/opensim/blob/master/OpenSim/Region/Framework/Scenes/Scene.cs#L4472 > > > and various other places scattered about throughout Scene.cs between > revisions c3138f9 and 625452b. It seems a lot of unbracketed single > statement if blocks, even multi-lined ones, had their indentation > stripped off. This is not a normal convention is any language I know > of. > > > -- > Cinder Roxley > Sent with Airmail > _______________________________________________ > Opensim-dev mailing list > [email protected] > http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev _______________________________________________ Opensim-dev mailing list [email protected] http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
