For unused variables it's better to comment the lines, ending them by a
comment like:
// the line of unused code; //Warning's Safari 20151121 1115
The commented lines of code are not to be removed especially with this
new version of the master; they are used to debug when something
regresses. But it should be the responsibility of the developer to date
these lines to differentiate very old comments which are useless.
Can I draw your attention to certain warnings that I have long ago and
for which I did not find any explanations?
(the code is compiled under Windows 10 with C # Express 2010)
Warning 11 '2008' is not a valid warning number OpenSim.Data
or
Warning 61 '2008' is not a valid warning number
OpenSim.Region.ScriptEngine.XEngine.Api.Runtime
There are 15 to 40 warnings such as those according to the master compiled.
Do you see these warnings and what it means in '2008'?
GL
Le 21/11/2015 10:14, Tom Frost a écrit :
Hi opensim devs,
On Fri, Nov 20, 2015 at 11:50:09PM +0100, Tom Frost wrote:
On Fri, Nov 20, 2015 at 02:33:53PM +0100, Melanie wrote:
a warning safari is highly appreciated. You don't need to create a
Mantis for each warning, simply create one for the warnings and
attach the patches to it. For pure warning removal with no
functional changes, the patches can be larger than what we usually
ask for with functional changes.
Alright, i've gone ahead and created this issue:
http://opensimulator.org/mantis/view.php?id=7746
and attached 13 patches to address a first batch of low-hanging
fruit. I thought it would be convenient for picking which ones
to apply.. But I can resubmit it as one large path if that
is preferred. Just let me know!
---+ Unused variables and warnings
I got this response:
'Hi, thanks but please stop for now :( You are also removing comments, dead
code,
etc, and that needs to be checked case by case, even some unused variables are
there waiting future use You removed for example debug messages that we put
back every time we
need. I can't apply patches like this automatically. I will use them as
reference. I did remove a few of those warnings, increasing the total reported
by 2
;)´
Unused variables that are there waiting for future use and that
generate warnings are in violation with the coding standards as stated
on http://opensimulator.org/wiki/Coding_standards:
"Warnings
Please keep the code warning free, using #pragma only if absolutely
necessary. For instance ..."
Are all the core devs aligned in the acceptance of the practice of
leaving in unused variables that generate warnings during compilation
because someone at some point may want to use them?
If so, please rewrite the coding standards, so that new people like me
don't waste their time.
---+ Debug statements and commented-out code
I'm ok with redoing the patches to leave in large fragments of
commented-out code and stray debug log statements that have been
commented out (if indeed all core devs are fine with the ugliness this
introduces into the codebase).
As for debug statements, wouldn't it be better to define them as such by
not commenting them out but leaving them in and make them conditional on
a variable that configures the debug level of logging?
---+ Bad attitude
As a sidenote, telling someone to 'please stop for now :(' is not very
productive. If I need to do things differently just say so, instead of
using discouraging wording. From the comment above it feels like my work
is not appreciated and i should not attempt to help out.
Please let me know how to proceed.
Thanks,
Tom
_______________________________________________
Opensim-dev mailing list
[email protected]
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
_______________________________________________
Opensim-dev mailing list
[email protected]
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
