Christopher Yeoh wrote: > On Mon, 27 Apr 2009 19:26:43 +0100 > Justin Clark-Casey <[email protected]> wrote: >>> This under most circumstances avoids including directory entries into the >>> archive. At one stage the dearchiver was made to be a bit more tolerant >>> of the input like that but the code appears to have regressed a bit. >> Is this definitely the case right now? From which I last effectively tested >> this (which wasn't that long ago), there >> were no problem with directory entries in the tar. If this is no longer the >> case then a bug report in Mantis with the >> offending oar file attached would be much appreciated. > > Definitely is the case right now (at least from yesterday's trunk). There used > to be a test in DearchiveRegion0DotStar that checked to see if the filetype > was a directory and to ignore it if that was the case. > > I've been meaning to send a patch for a while as its been annoying me but > I've been flat out. > If you look at the diff between r8857:8858 for > OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs > you can see where the directory test was removed. Sorry for being vague, am > not allowed to send a patch directly ;-)
I know the feeling, I've been in that situation myself ;) This should now be fixed in r9334 - I even extended the unit test to help make sure that it doesn't revert. Cheers, -- justincc Justin Clark-Casey http://justincc.wordpress.com _______________________________________________ Opensim-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/opensim-users
