Having had a quick look at our system, I've a feeling that we're using ':' more than we should within the abstract-type. Can I humbly suggest that if we do tighten up on URL checking, we make it optional to switch it on and leave it off by default?
cheers Matt -----Original Message----- From: John Calcote [mailto:john.calc...@gmail.com] Sent: 19 December 2011 16:20 To: 'Ian Norton'; OpenSLP Devel Mailing List Subject: Re: [Openslp-devel] proposed patch for OpenSLP Thank you very much for doing the testing Ian. We'll ensure we only commit code that passes valid URL schemes. John > -----Original Message----- > From: Ian Norton [mailto:inor...@gmail.com] > Sent: Monday, December 19, 2011 1:30 AM > To: John Calcote > Subject: Re: [Openslp-devel] proposed patch for OpenSLP > > Running this up in the attached test program I've not been able to > find any > addresses that are accepted. > > According to the RFC, here are some valid addresses. > > service:device-drivers:ftp://x3.bean.org/drivers/diskdrivers.drv > service:device-drivers:http://www.bean.org/drivers/drivpak.drv > > and the openslp docs > > service:weather.nasa:wtp://weather.nasa.com:12000 > service:weather.nasa:swtp://weather.nasa.com:12001 > service:chat.superchat://chat.superchat.com > > And going by how naming authority stuff goes. the following should be valid > too: > > service:x-private.name.authority:protocol://address:8888 > service:x-my-fancy-service.norton.ian:http://this.is.my.server > > Regards > > Ian > > On 19 December 2011 08:02, Ian Norton <inor...@gmail.com> wrote: > > I might be reading this wrong (it is rather early here) but it looks > > to me that this only permits the abstract part of the service type > > to contain only one "." which doesn't fit my interpretation of the RFC. > > > > Possibly the first break should be a continue. > > > > Also, (and it's early, I might be mis-reading this) this permits a > > service url of: > > > > service:x.:/x > > > > Ian > > > > > > On 16 December 2011 16:51, John Calcote <john.calc...@gmail.com> > wrote: > >> The patch looks ok to me - would someone mind committing it for > >> Michal and Tomas? I don't currently have a work area checked out > >> (updating my linux machine). > >> > >> Thanks, > >> John > >> > >>> -----Original Message----- > >>> From: Tomas Cech [mailto:tc...@suse.de] > >>> Sent: Friday, December 16, 2011 6:19 AM > >>> To: john.calc...@gmail.com > >>> Cc: openslp-devel@lists.sourceforge.net > >>> Subject: proposed patch for OpenSLP > >>> > >>> Hi, > >>> > >>> Michal Srb proposed feature request with patch implementing it > >>> > >>> > http://sourceforge.net/tracker/index.php?func=detail&aid=3454443&gro > >>> up > >>> _id=1730&atid=351730 > >>> > >>> but didn't receive any response yet. Is it acceptable for OpenSLP? > >>> Can someone review and apply? > >>> > >>> Thanks in advance. > >>> > >>> Tomas Cech > >> > >> > >> ------------------------------------------------------------------- > >> -- > >> --------- Learn Windows Azure Live! Tuesday, Dec 13, 2011 > >> Microsoft is holding a special Learn Windows Azure training event > >> for developers. It will provide a great way to learn Windows Azure > >> and what it provides. You can attend the event by watching it > >> streamed LIVE > online. > >> Learn more at http://p.sf.net/sfu/ms-windowsazure > >> _______________________________________________ > >> Openslp-devel mailing list > >> Openslp-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/openslp-devel ---------------------------------------------------------------------------- -- Learn Windows Azure Live! Tuesday, Dec 13, 2011 Microsoft is holding a special Learn Windows Azure training event for developers. It will provide a great way to learn Windows Azure and what it provides. You can attend the event by watching it streamed LIVE online. Learn more at http://p.sf.net/sfu/ms-windowsazure _______________________________________________ Openslp-devel mailing list Openslp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openslp-devel This email, including any attachment, is a confidential communication intended solely for the use of the individual or entity to whom it is addressed. It contains information which is private and may be proprietary or covered by legal professional privilege. If you have received this email in error, please notify the sender upon receipt, and immediately delete it from your system. Anything contained in this email that is not connected with the businesses of this company is neither endorsed by nor is the liability of this company. Whilst we have taken reasonable precautions to ensure that any attachment to this email has been swept for viruses, we cannot accept liability for any damage sustained as a result of software viruses, and would advise that you carry out your own virus checks before opening any attachment. ------------------------------------------------------------------------------ Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev _______________________________________________ Openslp-devel mailing list Openslp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openslp-devel
