On 11/13/07, Chris Gerhard <[EMAIL PROTECTED]> wrote: > Please can you review the changes to support: > > PSARC 2007/503: crontab entry environment variables > > 6518038 cron & crontab should support multiple timezone > > > The webrev is here: http://cr.opensolaris.org/~cjg/cron/webrev/ > > The changes introduce support for cron and crontab to understand the HOME, > SHELL and TZ variables so that jobs run in $HOME using the shell $SHELL and > in the timezone $TZ. Each of these variables can be set multiple times and > effect all subsequent lines in a crontab file until the variable is reset. > the variables are also propagated into the running jobs. > > Please respond by the close of November 27th 2007
In crontab.c it seems that the TZ, HOME and SHELL lines are blindly copied through. Should crontab do some minimal level of verification on the values? (What does cron do if they're bogus?) In cron.c, I see no need for the CANTCDHOME message to contain the second instance of "directory". Old: can't change directory to your home directory. New: can't change directory to /a/b/c directory. would look better if it just said: can't change directory to /a/b/c. Most of the rest of the code goes straight over the top of my head... -- -Peter Tribble http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/ _______________________________________________ opensolaris-code mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
