usr/src/cmd/cron/cron.c
Line 123: I would prefer that the CANTCDHOME message still contained
the "home" keyword. It may also benefit from expanding the errno in
the message, ("can't change directory to home: %s: %s", home, strerror(errno))
Line 125: Could also be modified to display the shell now that SHELL
may be specified.
Line 2363: Perhaps a little pedantic this one. The arbitrary buffer of
256 + PATH_MAX in-line may be missed by future change to the message.
Therefore it would in my opinion be better to either create a new
definition near the definition of CANTCDHOME or perhaps dynamically
calculate the required buffer size. The same buffer may also be used
for the new CANTEXECSH message.
This message posted from opensolaris.org
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
