> 1) The macros themselves that make use of _IOCPARM_MASK (_IOR, _IOW, > _IORW) are "private" to ON. That is, external code shouldn't be > directly using them. kqemu falls down here. I'm not sure we need to > worry about that.
But the macros are older than dirt and common in other Unices (e.g., the 4.2 BSD tree -- circa 1983 -- has 'em), so it seems a bit of a stretch to consider them private to ON. > 2) I did find *one* potential issue in ON, which is that struct > iftun_req has a size of 600. All other ioctls defined in ON header > files use sizes that won't be truncated. The ioctls impacted are > SIOCGTUNPARAM and SIOCSTUNPARAM. FWLIW, those ioctls are gone in the Clearview gate and will be gone from ON when Clearview IP Tunneling integrates. -- meem _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
