Peter Memishian wrote: > [ This is unrelated to the original topic; changing subject. It'd be nice > if we could stay on-point. ] > > > > > 2) I did find *one* potential issue in ON, which is that struct > > > > iftun_req has a size of 600. All other ioctls defined in ON header > > > > files use sizes that won't be truncated. The ioctls impacted are > > > > SIOCGTUNPARAM and SIOCSTUNPARAM. > > > > > > FWLIW, those ioctls are gone in the Clearview gate and will be gone from > > > ON when Clearview IP Tunneling integrates. > > > > OK, so let me ask a dumb question. If the ioctls are gone, are they > > used by any code outside of ON? They are certainly documented in > > tun(7M), but I'm inclined to believe that nothing uses them. > > Right, nothing uses them that we're aware of. > > > One of my biggest concerns, though, is punchin. I don't know if punchin > > makes use of them at all. (Dan McDonald: can you comment?) > > Dan McDonald has been an honorary member of our team on the tunneling > work and is well aware of the changes. > >
Yay. I'm very happy about this. I'll send out a flag day notice, but at the moment, I'm inclined to take no action at all. -- Garrett _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code