James Carlson 写道: > Garrett D'Amore writes: > >> James Carlson wrote: >> >>> Garrett D'Amore writes: >>> >>> >>>> There is a closed version, which includes one closed file fix, at >>>> >>>> http://jurassic.sfbay/~gd78059/webrev/mblkl >>>> > > "OK" on all the responses. > I am uncomfortable with some of the (void *) changes, for example, closed/uts/common/io/ib/clients/sdpib/sdp_link.c
from 102 /* LINTED */ 103 ipllc = (ipllc_t *)mp->b_rptr; 104 ipllc->ipllc_cmd = IP_IOC_RTS_REQUEST; to 102 ipllc = (void *)mp->b_rptr; 103 ipllc->ipllc_cmd = IP_IOC_RTS_REQUEST; Although (void *) makes lint happy, this change greatly dilutes the clarity of a structure pointer which gets used immediately to access member fields in that structure. I feel that we are bending too much to please the lint checker. > >>> uts/intel/pcwl/Makefile >>> >>> 75: remove >>> >>> >> Huh? You better clarify that one for me. >> > > Instead of actually removing the now-unused LINTTAGS += entry in this > one Makefile, you just commented it out. I think it'd be better to > remove the line. If anyone really needs it in the future, they'll > have to come up with the recipe on their own. > > -- Tzongyu Paul Lee, [EMAIL PROTECTED] or [EMAIL PROTECTED] BJS05 7225, x84343 http://blogs.sun.com/tpaullee/ Feel the Pulses of China http://tpaullee.blogspot.com/ - use google reader in China _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
