Tzongyu Paul Lee writes: > James Carlson \xE5\x86\x99\xE9\x81\x93: > > Garrett D'Amore writes: > >>>> http://jurassic.sfbay/~gd78059/webrev/mblkl > >>>> > > > > "OK" on all the responses. > > > I am uncomfortable with some of the (void *) changes, for example, > closed/uts/common/io/ib/clients/sdpib/sdp_link.c [...] > Although (void *) makes lint happy, this change > greatly dilutes the clarity of a structure pointer which > gets used immediately to access member fields in that structure. > I feel that we are bending too much to please the lint checker.
I'm not sure that "greatly" is fair. The cast does little, as the only possible structure that could be used here is the one with which the local variable was defined. It's not as though it controls anything about the definition. What I _think_ you're saying is that since these two must match, the cast serves as a timely reminder of what the local variable should be doing, somewhat nearer to the use. But that can be handled just as well by choosing good variable names and by keeping variable definitions close to their use -- both practices that good, maintainable code ought to employ anyway. I think the choice between (void *) and /* LINTED */ is rather arbitrary. Personally, I think I'd somewhat rather have /* LINTED */, as it makes the specific issue clearer. Garrett obviously feels otherwise. I have a hard time getting worked up about a style issue that small, so I didn't even mention it in review. -- James Carlson, Solaris Networking <[EMAIL PROTECTED]> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
_______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
