Hi all, Could someone please review the code changes necessary for delivering strsep() implementation into libc ?
webrev is here: http://cr.opensolaris.org/~vkotal/strsep_libc-webrev/ Here's breakdown of the changes: - addition of the function definition to libc - via move from passwdutil - obvious additions to libc Makefiles, mapfile, string.h, lint lib - thanks to PSARC 2008/309 we don't have to deal with synonyms anymore - removal of duplicate code: - from libsmb, libresolv2, ns_ldap - config.h changes to ssh, sendmail Both kernel and libraries need strsep() implementation [1]. I was thinking about separating strsep() from src/common/util/string.c into src/common/util/strsep.c (new file) and building both kernel and libc part from there. However, looking at most of the functions in src/common/util/*.c they have their counterparts in libc so I reverted to only leaving a comment in src/common/util/string.c (to avoid introducing an exception in how we build libc). The other thing I was not so sure of was the removal of strsep() from libsmb. I believe it is okay to plainly remove it from the mapfile since this is done in SUNWprivate section only and hence no library filtering is necessary. v. [1] There is actually only single call to strsep() in the whole uts. _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
