Hi Vlada, V pá, 18. 07. 2008 v 18:03, Vladimir Kotal píše: > Doug Leavitt wrote: > > Vladimir, > > Hi Doug, > > It's cool to see someone finally chimed in :) > > > A couple of things: > > > > 1) libresolv is a library tracked from the ISC bind9 distribution. > > So removing strsep from it is not something we do because we > > keep the code bases in sync, AFAIK. Think of it as SFW software > > before there really was a SFW gate. Ditto for sendmail. > > libresolv2 changes removed. > > I think you're only mentioning sendmail as an example of 3rd party > software living in ONNV and this comment has nothing to do with changes > done to usr/src/cmd/sendmail/db/config.h, correct ? >
I don't see reason why config.h should be changed. strsep() is available now, so your config.h is correct. > > 2) Secondly changing nss_ldap requires a significant amount of > > testing [usually 2 experienced engineers 2 full days] on in about > > 16 different combination runs: > > sparc/x86 x 32/64 x zones/no zones x normal/per-user > > [this requires setting us a DS 6.x directory server for both SSL and > > Kerberos]. > > 2 full days for experienced engineers means at least 1 full week for me. > This is stuff I do in my spare time and spreading full week over > evenings and nights is 1 month of my time. > > nss changes removed. > > I can file a low priority CR against the duplicities removal in each > particular libary after the changes are in if anyone cares. The goal of > this integration is to provide strsep() in libc. Think of the removal of > duplicities as extra bonus. > I know LDAP part of code, so, please, log P3 CR (code duplicity), I will fix it, including testing. > What about libsmb changes ? What about the rest of the changes ? > No idea, you should go to people from CIFS server team. [...] > webrev refreshed: > http://cr.opensolaris.org/~vkotal/strsep_libc-webrev/ > My knowledge of adding new functions to libc is limited, but I think the webrev is OK. Please, ask CIFS server people for their oppinion or log the second CR for CIFS server. Best regards, Milan _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
