I should've asked the question: (a) should gss_buffer_desc have uint32_t length or (b) should packet_get_string() use size_t? I think the latter is probably the more correct option.
Just to fill in the picture further. gcc defines __SIZE_TYPE__ that size_t needs to be typedef'd to (otherwise you get problems especially with g++ - the same goes for __WCHAR_TYPE__). In System Z gcc is built with __WCHAR_TYPE__ = unsigned long. Furthermore, -Wall -Werror causes gcc to flag all sorts of things - in effect doing quite a lot of what lint does. (Speaking of lint some of the gcc extensions like __attribute__() cause lint grief). While I'm rambling the greatest occurrence of changes I've had to make is for all those files in $SRC/cmd that specify "char c; ... c = getopt() != -1;". They assume that char is, by default, signed. However, for some platforms this is not true. I've had to go through and change char c; to int c; to match the definition of getopt() and prevent the warning saying that the test will always be false due to the datatypes involved. Neale -- This message posted from opensolaris.org _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
