Neale Ferguson writes: > I should've asked the question: (a) should gss_buffer_desc have uint32_t > length or (b) should packet_get_string() use size_t? I think the latter is > probably the more correct option.
There's another option: (c) should the handful of callers who errantly pass a size_t object by reference to a function taking a 'uint_t *' pointer be fixed? This looks like ssh/sshd/auth2-gss.c, ssh/ssh/sshconnect2.c, and the scary code in ssh/ssh/sshconnect1.c and to me. Everyone else seems to pass in the right flavor of pointer. > While I'm rambling the greatest occurrence of changes I've had to make is for > all those files in $SRC/cmd that specify "char c; ... c = getopt() != -1;". Yikes! Please file bugs. That's just "C Coding 101," and is completely wrong. -- James Carlson, Solaris Networking <[EMAIL PROTECTED]> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
