On 05/05/09 22:31, Garrett D'Amore wrote:
FYI, I've updated the hme webrev at
http://cr.opensolaris.org/~gdamore/hme-x86/
This version actually *works* with x86 platform now. :-) I'm going to
run nightlies, get SPARC binaries, and then I'll offer up both SPARC and
x86 binaries for testing. I'd *really* like to get folks to review the
changes.
Garrett,
[Not a full review, but having run into the 'hme PCI ROM not mapped on
x86' issue myself some years ago, I was curious to see how you solved that.]
Is calling ddi_walk_devs() from hmeget_promebus() allowed/safe? The
comments for ddi_walk_devs()[1] note that it is not callable from device
autoconfiguration routines such as attach(9E), which is what is
happening here.
If it is indeed safe to do so (I don't know), then maybe a comment
stating why it is ok might be appropriate.
Menno
[1]http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/os/devcfg.c#3478
--
Menno Lageman - Sun Microsystems - http://blogs.sun.com/menno
_______________________________________________
opensolaris-code mailing list
opensolaris-code@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
