Hi! ----
Can anyone review the patch in http://cr.opensolaris.org/~gisburn/cr_6712500_nightly_use_ksh93_001/ , please ? The basic changes are: - Switch the shell interpreter from ksh88 to ksh93 - Replace "foo()" with "function foo" since this is a difference between ksh88 and ksh93 - functions with "foo()" have a sepeate scope while ksh93 conforms to POSIX and does "foo()" not give a seperate scope (see http://www.opensolaris.org/os/project/shell/shellstyle/#use_ksh_style_function_syntax) - Add shell version information to the nightly log - "sort | uniq" ---> "sort -u" Notes: - The patch is the first of four patches to incrementally clean-up "nightly.sh". - This patch is _not_ intended to improve performace. This patch only switches "nightly.sh" from ksh88 to ksh93 to be in sync with "bldenv.sh" that users can actually use ksh93 statements in the "opensolaris.sh" config file and to prepare for later cleanup steps (my fear is that this patch will trigger a larger discussion again and a large patch may suffer from bitrot again (at least my last two nightly cleanup patches suffered that fate and I am not exactly willing anymore to write patches for /dev/null)). As said I now try to split the original monster-patch into smaller pieces to get them added to the tree faster. ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.ma...@nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;) _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
