Roland Mainz wrote:
Hi!
----
Can anyone review the patch in
http://cr.opensolaris.org/~gisburn/cr_6712500_nightly_use_ksh93_001/ ,
please ?
The basic changes are:
- Switch the shell interpreter from ksh88 to ksh93
I see there is no -p option used anymore with ksh93. Is this the default
behavior in ksh93 ?
- Replace "foo()" with "function foo" since this is a difference between
ksh88 and ksh93 - functions with "foo()" have a sepeate scope while
ksh93 conforms to POSIX and does "foo()" not give a seperate scope (see
http://www.opensolaris.org/os/project/shell/shellstyle/#use_ksh_style_function_syntax)
No problem with that.
- Add shell version information to the nightly log
Not sure this is actually needed. Also, why is there a check for shcomp
? How is it used in the context of nightly.sh ?
- "sort | uniq" ---> "sort -u"
Okay.
On line 530 you're changing grep -v "^$" to grep -v "^\$". The double
quotes are not necessary - what about using single quotes to avoid the
escape ?
Otherwise this looks good.
v.
_______________________________________________
opensolaris-code mailing list
opensolaris-code@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
