Hi Joerg, Joerg Schilling píše v so 01. 05. 2010 v 19:17 +0200: > James Carlson <carls...@workingcode.com> wrote: > > > > You Most of the code I see from Sun does not follow > > > these rules and the variable names are of course OK in a piece of code > > > that > > > is easy to read (all string sources in ON use tose 's' variables..... > > > Note that K&K function _implemetations_ are needed for portability and > > > that > > > there is no benefit from using ANSI C here as there are ANCI C function > > > _declarations_. > > > > > > I hope you know the difference between a function "declaration" and a > > > function > > > "implementation". > > > > Read the C style guide on the web site and try again. > > Irrelevant as long as nearly all current code in ON is similar to mine. >
There is a lot of code in ON gate which was written and integrated before "C style" was published. Such code is improved if the relevant part of source code is touched. Nobody will invest time to reformat all at once, of course. But including new code with different "C style" will not make the "C style" of ON gate better, but worse. Even some new code introduced to the ON gate is not following the "C style". I know two reasons for it (maybe there are others): 1) 'hg cstyle' check is not testing some corner case - then it should be improved. 2) new code is some "self-contained" thing (like ksh93) and it has explicit approval from ON C-team to avoid ON "C style" because it would complicate sync with upstream in future. Your code is not 1) neither 2). Please, follow the rules of ON gate if you want to contribute. It is common for many open source communities to follow their rules. [...] Best regards, Milan _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
