----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review152 -----------------------------------------------------------
scripts/install.py <http://codereview.secondlife.com/r/80/#comment93> I think for multiple return values, packaging in tuples is preferred over packaging in lists.[citation needed] I.e., use return (to_install, to_uninstall) scripts/install.py <http://codereview.secondlife.com/r/80/#comment92> This can be written more pythonesque as (to_install, to_uninstall) = self._build_ifiles(platform, cache_dir) scripts/install.py <http://codereview.secondlife.com/r/80/#comment94> Does to_install need filtering at all? (Can it contain non-installables?) - Boroondas On Jan. 14, 2011, 12:26 p.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/80/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2011, 12:26 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > See https://jira.secondlife.com/browse/VWR-24311 > > Basically, this fixes the TODO comment in install.py but with the difference > that we really want to uninstall any old package with the same name, > different md5 or not. > > > This addresses bug VWR-24311. > http://jira.secondlife.com/browse/VWR-24311 > > > Diffs > ----- > > doc/contributions.txt b0bd26c5638a > scripts/install.py b0bd26c5638a > > Diff: http://codereview.secondlife.com/r/80/diff > > > Testing > ------- > > Loads of testing on linux... Installing new packages now cleanly removes the > old one first. > > > Thanks, > > Aleric > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
