----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review167 -----------------------------------------------------------
Ship it! scripts/install.py <http://codereview.secondlife.com/r/80/#comment106> Please add a comment "regular directories (no symlinks)" ... scripts/install.py <http://codereview.secondlife.com/r/80/#comment107> ... and here a comment "regular files and symlinks", so that the intention behind these conditionals is clear to people unfamiliar with the used os.path functions. Other than that, I'd say it's ready. Great work! - Boroondas On Jan. 16, 2011, 5:35 a.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/80/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2011, 5:35 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > See https://jira.secondlife.com/browse/VWR-24311 > > Basically, this fixes the TODO comment in install.py but with the difference > that we really want to uninstall any old package with the same name, > different md5 or not. > > > This addresses bug VWR-24311. > http://jira.secondlife.com/browse/VWR-24311 > > > Diffs > ----- > > doc/contributions.txt 422f636c3343 > scripts/install.py 422f636c3343 > > Diff: http://codereview.secondlife.com/r/80/diff > > > Testing > ------- > > Loads of testing on linux... Installing new packages now cleanly removes the > old one first. > > > Thanks, > > Aleric > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
